Chris/webperl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Switched dynamic module loading to use Module::Load

Browse Source 
Dynamic loading was being done using require, but because of require's
rather idosyncratic behaviour it would fail if modules had :: in their
names (needs to be converted to / to avoid issues). Module::Load handles
all the shenanigans nicely...
This commit is contained in:
Chris 2012-03-17 11:14:52 +00:00
parent 7b0115c5cb
commit ac474f6ad2
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
AuthMethods.pm
View File

@ -25,6 +25,7 @@
package AuthMethods;
use strict;
use Module::Load;
our $errstr;
@ -139,7 +140,7 @@ sub load_method {
my $name = $module -> {"perl_module"};
no strict "refs"; # must disable strict references to allow named module loading.
eval "require $name";
eval { load $name };
die "Unable to load auth module $name: $@" if($@);
my $methodobj = $name -> new(%settings);

3
Modules.pm
View File

@ -24,6 +24,7 @@ package Modules;
#use lib qw(/home/webperl); # modules needed for utils, blocks needed for plugins
use DBI;
use Module::Load;
use Logging qw(die_log);
use strict;
@ -219,7 +220,7 @@ sub _new_module_internal {
my $name = $modrow -> {"perl_module"};
no strict "refs"; # must disable strict references to allow named module loading.
eval "require $name";
eval { load $name };
die "Unable to load module $name: $@" if($@);
# Set up the module argument hash...