Remove long-redundant phpBB3 support code

Webperl/Application.pm

@@ -76,12 +76,10 @@ BEGIN {
 #   If a relative path is provided, it is assumed to be relative to the index.cgi
 # - `scriptpath`, the path to the directory containing index.cgi. This is needed for
 #   scripts running inside mod_perl that may not have cwd set correctly.
-# - `use_phpbb`, if set, the phpBB3 support module is loaded (and takes over auth: the
-#   `auth` argument is ignored if `use_phpbb` is set).
 # - `appuser`, a reference to a Webperl::AppUser subclass object to do application-specific
-#   user tasks during auth. Can be omitted if use_phpbb is set.
+#   user tasks during auth.
-# - `auth`, an optional reference to an auth object. If not specified, and `use_phpbb`
+# - `auth`, an optional reference to an auth object. If not specified, a Webperl::Auth
-#   is not set, a Webperl::Auth object is made for you.
+#    object is made for you.
 # - `block_selector`, an optional reference to a Webperl::BlockSelector subclass. If not
 #   specified, the default Webperl::BlockSelector is used instead to provide standard
 #   block selection behaviour.
@@ -99,7 +97,6 @@ sub new {
     my $class    = ref($invocant) || $invocant;
     my $self     = {
         config    => "config/site.cfg",
-        use_phpbb => 0,
         post_max  => 128,
         @_,
     };
@@ -168,23 +165,6 @@ sub run {
                                                      settings  => $self -> {"settings"})
         or $self -> {"logger"} -> die_log($self -> {"cgi"} -> remote_host(), "Application: Unable to create template handling object: ".$Webperl::Template::errstr);
 
-    # If phpbb mode is enabled, it takes over auth.
-    if($self -> {"use_phpbb"}) {
-        load Webperl::phpBB3;
-        $self -> {"phpbb"} = Webperl::phpBB3 -> new(logger   => $self -> {"logger"},
-                                                    prefix   => $self -> {"settings"} -> {"database"} -> {"phpbb_prefix"},
-                                                    cgi      => $self -> {"cgi"},
-                                                    data_src => $self -> {"settings"} -> {"database"} -> {"phpbb_database"},
-                                                    username => $self -> {"settings"} -> {"database"} -> {"phpbb_username"},
-                                                    password => $self -> {"settings"} -> {"database"} -> {"phpbb_password"},
-                                                    codepath => path_join($self -> {"settings"} -> {"config"} -> {"base"}, "templates", "default"),
-                                                    url      => $self -> {"settings"} -> {"config"} -> {"forumurl"})
-            or $self -> {"logger"} -> die_log($self -> {"cgi"} -> remote_host(), "Unable to create phpbb object: ".$Webperl::phpBB3::errstr);
-
-        $self -> {"auth"} = $self -> {"phpbb"};
-
-    # phpBB3 is not enabled, initialise the auth modules.
-    } else {
     # Initialise the appuser object
     $self -> {"appuser"} -> init($self -> {"cgi"}, $self -> {"dbh"}, $self -> {"settings"}, $self -> {"logger"});
 
@@ -193,7 +173,6 @@ sub run {
 
     # Initialise the auth object
     $self -> {"auth"} -> init($self -> {"cgi"}, $self -> {"dbh"}, $self -> {"appuser"}, $self -> {"settings"}, $self -> {"logger"});
-    }
 
     # Start the session engine...
     $self -> {"session"} = Webperl::SessionHandler -> new(logger   => $self -> {"logger"},
@@ -225,7 +204,6 @@ sub run {
                                                    settings => $self -> {"settings"},
                                                    template => $self -> {"template"},
                                                    session  => $self -> {"session"},
-                                                   phpbb    => $self -> {"phpbb"}, # this will handily be undef if phpbb mode is disabled
                                                    blockdir => $self -> {"settings"} -> {"paths"} -> {"blocks"} || "blocks",
                                                    system   => $self -> {"system"},
                                                    messages => $self -> {"messages"})
@@ -240,7 +218,6 @@ sub run {
                                     settings => $self -> {"settings"},
                                     template => $self -> {"template"},
                                     session  => $self -> {"session"},
-                                    phpbb    => $self -> {"phpbb"},
                                     modules  => $self -> {"modules"},
                                     messages => $self -> {"messages"})
             or $self -> {"logger"} -> die_log($self -> {"cgi"} -> remote_host(), "Application: Unable to create system object: ".$self -> {"system"} -> errstr());

Webperl/Block.pm

@@ -51,7 +51,6 @@ use HTML::Entities;
 # - `args`     Any arguments passed to the plugin at runtime, usually pulled from the database.
 # - `cgi`      A reference to the script's CGI object.
 # - `dbh`      A database handle to talk to the database through.
-# - `phpbb`    A phpbb3 handle object used to perform operations on a phpbb3 database.
 # - `template` A template engine module object to load templates through.
 # - `settings` The global configuration hashref.
 # - `session`  A reference to the current session object

Webperl/SessionHandler.pm

@@ -80,10 +80,6 @@
 #   from the point of view of using the id as part of session id calculation. The extra
 #   argument allows the addition of an arbitrary string to the seed used to create the id.
 #
-# This code is heavily based around the session code used by phpBB3, with
-# features removed or added to fit the different requirements of the
-# framework.
-#
 # This class requires three database tables: one for sessions, one for session keys (used
 # for autologin), and one for session variables. If autologins are permanently disabled
 # (that is, you can guarantee that `get_config("allow_autologin")` always returns false)