From 02caf90c4f245f331a35417a2c69475a23d526d8 Mon Sep 17 00:00:00 2001 From: Chris Date: Mon, 19 Sep 2011 11:54:53 +0100 Subject: [PATCH] When iterating over hash keys, it is a good idea to use keys()! --- Modules.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Modules.pm b/Modules.pm index eb22725..bab3411 100644 --- a/Modules.pm +++ b/Modules.pm @@ -191,8 +191,8 @@ sub _new_module_internal { "args" => $modarg, "module" => $self, ); - foreach my $key (%{$self}) { - $args{$key} = $self -> {$key} if(!defined($args{$key}) && defined($self -> {$key})); + foreach my $key (keys(%{$self})) { + $args{$key} = $self -> {$key} if(!defined($args{$key})); } my $modobj = $name -> new(%args)