From 670d320e8893ab916f82ac7ba9cf8e5329b3dc2e Mon Sep 17 00:00:00 2001
From: Chris <chris@starforge.co.uk>
Date: Sat, 28 Sep 2019 11:56:01 +0100
Subject: [PATCH] Rearrange steps of code in edit to catch problems more
 reliably

---
 modules/ORB/System/Recipe.pm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/modules/ORB/System/Recipe.pm b/modules/ORB/System/Recipe.pm
index 4e695da..4768722 100644
--- a/modules/ORB/System/Recipe.pm
+++ b/modules/ORB/System/Recipe.pm
@@ -229,20 +229,20 @@ sub edit {
 
     $self -> {"logger"} -> log("recipe.edit", $args -> {"creator_id"}, "unknown", "Renumbered ".$args -> {"id"}." as $renumbered");
 
-    # Clear the original ID for the master.
-    $args -> {"origid"} = undef;
-
-    # Create the new recipe at the old ID
-    $self -> create($args)
-        or return undef;
-
     # Set the status of the edited recipe
     $self -> set_status($renumbered,
                         $self -> {"settings"} -> {"config"} -> {"Recipe:status:edited"} // "Edited",
                         $args -> {"updaterid"})
         or return undef;
 
-    return $args -> {"id"};
+
+    # Clear the original ID for the master.
+    $args -> {"origid"} = undef;
+
+    $self -> {"logger"} -> log("recipe.edit", $args -> {"creator_id"}, "unknown", "Creating new version of recipe at ".$args -> {"id"});
+
+    # Create the new recipe at the old ID
+    return $self -> create($args);
 }